fix: Helm execution_api_server_url when base_url has a subpath

[LucasRoesler]

When the config.core.base_url has a subpath, this path should be copied to the execution_api_server_url as a path-prefix.

For example, when base_url=http://example.com/airflow, then the execution_api_server_url=http://name-api-server:8080/airflow/execution

The chart behavior is unchanged if

• the base_url is empty
• the base_url does not have a subpath
• the execution_api_server_url is already set in the config

This can easily be tested using helm template, here are the 4 cases I considered

1. No config overrides will produce the current behavior

   $ helm template local ./  -s templates/configmaps/configmap.yaml | grep "execution_api_server_url"
       execution_api_server_url = http://local-api-server:8080/execution/

2. Adding a base_url with a sub-path shows the new behavior of copying the subpath to the execution url

   $ helm template local ./ --set config.api.base_url="http://example.com/airflow"  -s templates/configmaps/configmap.yaml | grep "execution_api_server_url"
       execution_api_server_url = http://local-api-server:8080/airflow/execution/

3. Adding a base_url without a subpath also preserves the existing behavior

   $ helm template local ./ --set config.api.base_url="http://example.com/"  -s templates/configmaps/configmap.yaml | grep "execution_api_server_url"
       execution_api_server_url = http://local-api-server:8080/execution/

4. Finallly, even adding a subpath to the base url, if the execution url is directly set, this is preserved

   $ helm template local ./ --set config.api.base_url="http://example.com/airflow" --set config.core.execution_api_server_url="http://service:9090/execution/"  -s templates/configmaps/configmap.yaml
    | grep "execution_api_server_url"
       execution_api_server_url = http://service:9090/execution/

Closes: #51450

---

[romsharon98]

Can you add some tests with those examples you written?

[LucasRoesler]

Sure thing, I initially missed the tests here: https://github.com/apache/airflow/blob/main/helm-tests%2Ftests%2Fhelm_tests%2Fairflow_core%2Ftest_api_server.py

I will add a new test case today.

[LucasRoesler]

@romsharon98 done, i add 4 cases for airflow > v3 and one for <v3. Let me know if there are other cases we want to include.

[LucasRoesler]

The test failure seems unrelated

Check and fix default value of default_deferrable...........................Failed
- hook id: check-deferrable-default
- exit code: 1

Traceback (most recent call last):
  File "/home/runner/work/airflow/airflow/./scripts/ci/pre_commit/check_deferrable_default.py", line 29, in <module>
    from libcst.codemod import CodemodContext
  File "/home/runner/.cache/pre-commit/repodmrse7ww/py_env-python3/lib/python3.9/site-packages/libcst/codemod/__init__.py", line 6, in <module>
    from libcst.codemod._cli import (
  File "/home/runner/.cache/pre-commit/repodmrse7ww/py_env-python3/lib/python3.9/site-packages/libcst/codemod/_cli.py", line 29, in <module>
    from libcst.codemod._dummy_pool import DummyExecutor
  File "/home/runner/.cache/pre-commit/repodmrse7ww/py_env-python3/lib/python3.9/site-packages/libcst/codemod/_dummy_pool.py", line 14, in <module>
    from typing_extensions import ParamSpec
ModuleNotFoundError: No module named 'typing_extensions'

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.