-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix: allow users with specific DAG permissions to access DAGs when no pecific DAG is requested #51462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Who is able to merge this in and when can we expect this bug fix to be released? Thanks. |
Tests are failing, can you please take a look and fix them? |
Any committer can merge this once approved and the CI is green. Provider only change -> next fab provider release (every 2 weeks or so) |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks.
|
@pierrejeambrun @vincbeck Updated tests, please approve the workflows to be executed, thanks! |
… specific DAG is requested
e519d5a to
5231731
Compare
|
@vincbeck updated again, please approve workflows. |
|
@vincbeck the build passed , https://github.com/apache/airflow/actions/runs/15563154053/job/43821886590?pr=51462 , I clicked |
|
not sure if you're able to merge this in, thanks |
|
All good 👌 Thanks for fixing the tests! Merging |
|
@pierrejeambrun not sure about the backport, it is a provider only change. |
…DAGs when no pecific DAG is requested (#51462) * Fix: allow users with specific DAG permissions to access DAGs when no specific DAG is requested * Fix: Update unit tests to handle new DAG authorization behavior --------- (cherry picked from commit 8da0160) Co-authored-by: Will Yang <willyyang604@gmail.com> Co-authored-by: Will Yang <will@wcs-northamerica.com>
closes: #51325
fix: authorize users with specific DAG permissions for general DAG operations
Allow users with specific DAG permissions (e.g., "DAG:my_dag") to access
DAG-related endpoints when no specific DAG is requested, instead of denying
access. Users are authorized if they have access to at least one DAG.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.