Skip to content

Conversation

@fuatcakici
Copy link
Contributor

The parameter in WorkflowTrigger is "execution_dates", and not "execution_date"


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The parameter in WorkflowTrigger is "execution_dates", and not "execution_date"
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the parameter name passed to WorkflowTrigger in ExternalTaskSensor.execute, ensuring the key matches the expected “execution_dates” signature.

  • Changed the dict key from "execution_date" to "execution_dates" when not running Airflow v3.0+
  • Aligns sensor payload with the trigger’s parameter name

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuatcakici Welcome to Apache Airflow! This is a great catch :)
I hope that you will excuse me, but I took over the PR to add some tests so we'd be able to track such errors for the next times.
While adding the tests, I've found another related bug which I fixed on the way - I tagged the relevant commiters for their review.
Thanks for your contribution!

@shahar1 shahar1 requested review from gopidesupavan and kaxil June 6, 2025 14:41
@fuatcakici
Copy link
Contributor Author

@shahar1 of course, by all means!

I had also noticed the other bug by the way, as in the DagRun object not having the run_after parameter, but I did not see it raising any errors so I just assumed that I was overlooking something, so I'm glad to see it actually 😄

In any case, thanks for being so proactive!

@kaxil
Copy link
Member

kaxil commented Jun 6, 2025

@shahar1 We should update the PR title now to match the bug fix

@shahar1 shahar1 changed the title Fix typo in ExternalTaskSensor Fix Airflow V2 incompatibility in ExternalTaskSensor Jun 6, 2025
@shahar1 shahar1 merged commit e68ef6a into apache:main Jun 6, 2025
97 checks passed
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
kevinhongzl pushed a commit to kevinhongzl/airflow that referenced this pull request Jun 7, 2025
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants