Use attribute based access control in KeycloakAuthManager#51486
Merged
vincbeck merged 1 commit intoapache:mainfrom Jun 9, 2025
Merged
Use attribute based access control in KeycloakAuthManager#51486vincbeck merged 1 commit intoapache:mainfrom
KeycloakAuthManager#51486vincbeck merged 1 commit intoapache:mainfrom
Conversation
bugraoz93
approved these changes
Jun 6, 2025
Contributor
bugraoz93
left a comment
There was a problem hiding this comment.
This is an amazing addition! Thanks, Vincent!
Small update: I have started working on one of the items. I will share as a pull request soon. Most parts done, I need to add some refresh in the auth manager and make the calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on implementing
is_authorized_dagI realized using ABAC (attribute based access control) would makes more sense and simplify everything. In the previous implementation, for each access control, we were checking:Example. If a user tries to access the variable
test, we were checking whether the user has access to all variables, if not, we were checking whether the user has access to the variabletest.Now we are doing only one check: whether the user has access to variables and pass the variable key as an attribute. On Keycloak side then, it is up to the admin to use these attributes in policies. You can see examples of such policies here.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.