Skip to content

Conversation

@pierceroberts
Copy link
Contributor

@pierceroberts pierceroberts commented Jun 7, 2025


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Related to: #50937

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 7, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@pierceroberts
Copy link
Contributor Author

@rawwar Feel free to add comments, I am going to continue chipping away at this.
Also is there a location you can point me to in order to run tests successfully? I have been getting import errors with test_common... Thanks!

@pierceroberts
Copy link
Contributor Author

Interestingly I was getting this error on a single test:

FAILED providers/airbyte/tests/unit/airbyte/operators/test_airbyte.py::TestAirbyteTriggerSyncOp::test_on_kill - airflow.exceptions.AirflowException: Invalid URL 'airbyte.com/jobs/1': No scheme supplied. Perhaps you meant https://airbyte.com/jobs/1?

But it was nothing I changed, should I further investigate @rawwar or @sjyangkevin? As I did not make changes to that file, I left it.

Also this PR is now ready for review.
Thanks

@pierceroberts pierceroberts marked this pull request as ready for review July 7, 2025 05:18
@pierceroberts
Copy link
Contributor Author

@potiuk Looks like the pipeline is getting similar issues that I was getting like the Invalid URL 'airbyte.com/jobs/1': No scheme supplied.
I can fix the one that is related to the log implemented, but as for those other errors, I don't know what they are because I didn't actually do anything to effect those tests...

@potiuk
Copy link
Member

potiuk commented Aug 3, 2025

@potiuk Looks like the pipeline is getting similar issues that I was getting like the Invalid URL 'airbyte.com/jobs/1': No scheme supplied. I can fix the one that is related to the log implemented, but as for those other errors, I don't know what they are because I didn't actually do anything to effect those tests...

Well - it looks like the methods you use in debug logging are simply passed wrong parameters ... But that's something you should fix. Look at the contributinig guide how to run the tests locally and fix it, but those errors are for sure intriduced by your changes and it's up ot you to fix them.

@pierceroberts
Copy link
Contributor Author

Well - it looks like the methods you use in debug logging are simply passed wrong parameters ... But that's something you should fix. Look at the contributinig guide how to run the tests locally and fix it, but those errors are for sure intriduced by your changes and it's up ot you to fix them.

@potiuk I believe I fixed the pipeline as they now pass locally, I tried to merge main to get the pipeline to run but I don't think I have the power to trigger it with just commits...

@pierceroberts pierceroberts requested a review from potiuk August 3, 2025 19:44
@potiuk
Copy link
Member

potiuk commented Aug 3, 2025

Approved workflows.

@potiuk potiuk merged commit ea1dc0a into apache:main Aug 4, 2025
7 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 4, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
* 50937, init of debug logging

* add more debug logs.

* 50937, fix broken tests.

* Update .gitignore

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
* 50937, init of debug logging

* add more debug logs.

* 50937, fix broken tests.

* Update .gitignore

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants