-
Notifications
You must be signed in to change notification settings - Fork 16.3k
50937, add debug logging for airbyte #51503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@rawwar Feel free to add comments, I am going to continue chipping away at this. |
|
Interestingly I was getting this error on a single test: But it was nothing I changed, should I further investigate @rawwar or @sjyangkevin? As I did not make changes to that file, I left it. Also this PR is now ready for review. |
|
@potiuk Looks like the pipeline is getting similar issues that I was getting like the |
Well - it looks like the methods you use in debug logging are simply passed wrong parameters ... But that's something you should fix. Look at the contributinig guide how to run the tests locally and fix it, but those errors are for sure intriduced by your changes and it's up ot you to fix them. |
@potiuk I believe I fixed the pipeline as they now pass locally, I tried to merge main to get the pipeline to run but I don't think I have the power to trigger it with just commits... |
|
Approved workflows. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* 50937, init of debug logging * add more debug logs. * 50937, fix broken tests. * Update .gitignore --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
* 50937, init of debug logging * add more debug logs. * 50937, fix broken tests. * Update .gitignore --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.Related to: #50937