Add config setting to control exposing stacktraces #51509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhongzl
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
potiuk
approved these changes
Jun 7, 2025
potiuk
reviewed
Jun 7, 2025
kevinhongzl
force-pushed
the
add-config-setting-to-control-exposing-stacktraces
branch
from
13b1889 to
1a68ec2
Compare
potiuk
reviewed
Jun 9, 2025
kevinhongzl
force-pushed
the
add-config-setting-to-control-exposing-stacktraces
branch
from
98d8518 to
d4ad121
Compare
potiuk
approved these changes
Jun 9, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
A very small nit - it would be nice to add a test where get_random_string is patched and the patched value is returned, rather than passing hard-coded id.
kevinhongzl
force-pushed
the
add-config-setting-to-control-exposing-stacktraces
branch
from
07e90a0 to
6452ef5
Compare
Contributor
Author
|
I removed |
kevinhongzl
force-pushed
the
add-config-setting-to-control-exposing-stacktraces
branch
from
6452ef5 to
4864e00
Compare
potiuk
reviewed
Jun 9, 2025
jason810496
approved these changes
Jun 10, 2025
kevinhongzl
force-pushed
the
add-config-setting-to-control-exposing-stacktraces
branch
from
8c5bf54 to
51d59bb
Compare
potiuk
approved these changes
Jun 10, 2025
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 11, 2025
* feat: add a config setting to expose stacktraces * fix: remove the starting newline to simplify the traceback info * test: update tests to align with the config change * feat: add exception id for better correlation between ui messages and log entries * test: update tests * fix: use random string as exception id instead of python object id * fix: update tests with patched random strings * test: use patch fixtures in tests to prevent side effects (cherry picked from commit c4cd58c)
Member
|
Manual backport #51617 |
pierrejeambrun
added a commit
that referenced
this pull request
Jun 11, 2025
* feat: add a config setting to expose stacktraces * fix: remove the starting newline to simplify the traceback info * test: update tests to align with the config change * feat: add exception id for better correlation between ui messages and log entries * test: update tests * fix: use random string as exception id instead of python object id * fix: update tests with patched random strings * test: use patch fixtures in tests to prevent side effects (cherry picked from commit c4cd58c) Co-authored-by: Zhen-Lun (Kevin) Hong <zhenlun.hong01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #51351
(Sorry for accidentally messing up the commit history. I created a new PR for this issue)
Why
This PR reintroduces expose_stacktrace to control whether tracebacks are displayed in the webserver UI.
What
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.