Fix MaxComputeSQLOperator Argument #51513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @Lee-W , sorry, just found out my previous PR introduced some bugs when doing some refactor. I have tested this again using the system test from my side. Do you mind reviewing this? |
jsjasonseba
commented
Jun 8, 2025
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Show resolved
Hide resolved
Lee-W
reviewed
Jun 9, 2025
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/operators/maxcompute.py
Show resolved
Hide resolved
Lee-W
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MaxComputeSQLOperator has errors due to incorrect argument usage. This PR fixes the conn_id argument naming and the fallback logic
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.