fix: make query_ids in SnowflakeSqlApiOperator in deferrable mode consistent #51542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few fixes included in this PR:
SnowflakeSqlApiHook.execute_querywill now consistently reset query_ids each time it's called, exactly likeSnowflakeHook.rundoes. Currently the behavior depended on number of queries executed, which could cause getting query_ids from previous execution as an attribute - sometimes it was overwritten, sometimes not.SnowflakeSqlApiTriggerwill now return the query_ids of query actually executed, instead of child query_ids of multi-statement queries, which is consistent with non-deferrable behavior that we have right now. This change makes the behavior consistent regardless of execution mode.SnowflakeSqlApiOperator, so that the listeners can use that information and have consistent behavior regardless of execution mode.SnowflakeSqlApiHookinSnowflakeSqlApiOperator, right now the property of super classSQLExecuteQueryOperatorwas overwritten during execution, which could lead to inconsistencies, depending on when you ask forSnowflakeSqlApiOperator._hook.self.query_idsdefinition in init ofSnowflakeSqlApiOperatorAdded tests for all changes.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.