Skip to content

Conversation

@molcay
Copy link
Contributor

@molcay molcay commented Jun 10, 2025

This PR will change the Link implementation in Google Provider to make it clean.

The PR consists of the following:

  • Move the not standardized persist method to the base class.
  • Define extra_links_params method in the operator level to pass static arguments (project_id, location, etc) to the link

I was also planning to get rid of all persist calls with only the operator properties but I realized that the operator instance (operator: BaseOperator) in the get_link method is different in Airflow 2 and 3. Hence, for Airflow 3, on the operator side we don't need to use Link.persist(context=context) but for Airflow 2 we need to use it. After fully migrating to Airflow 3 we may get rid of all usage of persist with context=context


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@molcay molcay force-pushed the refactor-links-for-google-provider branch from 325310c to 96d6a17 Compare June 11, 2025 09:07
@VladaZakharova
Copy link
Contributor

Hi @potiuk !
Can you please check this one? A big update for the Google provider.
Thanks :)

@potiuk
Copy link
Member

potiuk commented Jun 17, 2025

Ineed huge change but easy to review as most of it is the same. Currently Conflicts need to be resolved but I already reviewed it and it's good to go as long as CI agrees.

@molcay molcay force-pushed the refactor-links-for-google-provider branch 3 times, most recently from 3c82acd to 0bd7a35 Compare June 17, 2025 15:56
@molcay molcay force-pushed the refactor-links-for-google-provider branch from 0bd7a35 to e30bdeb Compare June 18, 2025 08:33
@molcay
Copy link
Contributor Author

molcay commented Jun 18, 2025

@potiuk, I think the CI is finally green :)
and also thank you for the review 🙇🏼

@potiuk potiuk merged commit 4abeb0b into apache:main Jun 18, 2025
70 checks passed
@potiuk
Copy link
Member

potiuk commented Jun 18, 2025

🎉

@molcay molcay deleted the refactor-links-for-google-provider branch June 18, 2025 09:10
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants