Explicitly close log file descriptor in the supervise function#51627
Merged
ashb merged 8 commits intoapache:mainfrom Jun 12, 2025
Merged
Explicitly close log file descriptor in the supervise function#51627ashb merged 8 commits intoapache:mainfrom
ashb merged 8 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@kaxil hi, do I need to write tests here? (looks like as a non-trivial case) |
Member
|
Yeah but Mypy is failing though: |
ashb
reviewed
Jun 12, 2025
ashb
approved these changes
Jun 12, 2025
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
uranusjr
approved these changes
Jun 12, 2025
Contributor
Author
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Jun 14, 2025
…e#51627) We didn't close log file descriptor properly hence leading to too many open files error from the operating system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Airflow doesn't close log file descriptor properly hence leading to
too many open fileserror from the operating system.closes: #51624