Move return statement so that the rest of the function is reachable #51701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
backport-to-v3-1-test
Contributor
Author
|
Hi @uranusjr, thanks again for the review! Would you mind helping merge this PR when you get a chance? 😄 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
(cherry picked from commit e55464a) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 2, 2025
(cherry picked from commit e55464a) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
uranusjr
pushed a commit
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
When I was studying issue #51320, I found there is an indentation issue that causes the code after the first
return Falseto never be reached.Hence, I'm submitting this PR. If this was intentional, please let me know.