Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 13, 2025


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk added the canary When set on PR running from apache repo - behave as canary run label Jun 13, 2025
@potiuk potiuk force-pushed the bump-problematic-dependencies branch from 6a0995e to de0a6b2 Compare June 14, 2025 07:09
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see!

@jscheffl
Copy link
Contributor

What is your approach for such selection? Taking the package with the most number of releases since the lower pin you find in the repo?

@potiuk potiuk merged commit 99e0cc8 into main Jun 14, 2025
78 checks passed
@potiuk potiuk deleted the bump-problematic-dependencies branch June 14, 2025 09:00
@potiuk
Copy link
Member Author

potiuk commented Jun 14, 2025

What is your approach for such selection? Taking the package with the most number of releases since the lower pin you find in the repo?

Pure guessing. .. Maybe @notatallshaw might have some better hints? FYI @notatallshaw -> we again had problems with backtracking with pip -> https://github.com/apache/airflow/actions/runs/15647299212/job/44088044699#step:9:5090

@potiuk
Copy link
Member Author

potiuk commented Jun 14, 2025

Added pypa/pip#13281 (comment) -> maybe Damian will be able to help again.

@notatallshaw
Copy link
Contributor

FYI I can reproduce it and am taking a look, no promises, but if I can find a solution I will open a PR.

@potiuk
Copy link
Member Author

potiuk commented Jun 14, 2025

🙇 🙇

@notatallshaw
Copy link
Contributor

Btw, I've also merged sarugaku/resolvelib#188 which I hope to get in to pip 25.2.

This will restore the biggest optimization, for most cases, that was available in 25.0 and lost in 25.1.

25.1 also added several other optimizations, and I am experimenting with an additional optimization which I think will particularly benefit Airflow's CI, so I'm hopeful 25.2 will be a lot less problematic for you.

@notatallshaw
Copy link
Contributor

@potiuk PR available #51742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers canary When set on PR running from apache repo - behave as canary run provider:mysql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants