Add MwaaTaskSensor to Amazon Provider Package #51719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon
eladkal
previously requested changes
Jun 15, 2025
providers/amazon/src/airflow/providers/amazon/aws/triggers/mwaa.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/triggers/mwaa.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/sensors/mwaa.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/sensors/mwaa.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/triggers/mwaa.py
Outdated
Show resolved
Hide resolved
Contributor
Wouldn't it still wait for the dag run to complete? I think in this case the waiting would always be in deferrable mode instead of using the config value for If we want to test the sensor during execution, we could run the dag again in another task before the sensor task but I'm not sure if we want to be that exhaustive in system tests |
Contributor
Author
@ramitkataria With |
Contributor
Also discussed offline but in short, the sensor task would still wait for this task because the sensor task is set to depend on this task since they're in a chain |
… adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress.
Contributor
Author
|
I see that the commit message is rendering weird above so I'll rewrite it here for clarity:
|
o-nikolas
reviewed
Jun 24, 2025
providers/amazon/src/airflow/providers/amazon/aws/sensors/mwaa.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/sensors/mwaa.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/triggers/mwaa.py
Outdated
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/triggers/mwaa.py
Outdated
Show resolved
Hide resolved
- Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding.
This was referenced Jul 8, 2025
Contributor
Author
|
The two threads still in need of confirmation are: #51719 (comment) and #51719 (comment) |
seanghaeli
requested review from
bolkedebruin,
ephraimbuddy and
jedcunningham
as code owners
seanghaeli
requested review from
XD-DENG,
bugraoz93,
rawwar and
shubhamraj-git
as code owners
seanghaeli
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 23, 2025
- Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding.
seanghaeli
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 23, 2025
- Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding.
seanghaeli
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 23, 2025
- Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding.
Contributor
|
Bad rebase @seanghaeli I think. You might want to undo it |
seanghaeli
force-pushed
the
ghaeli/mwaa-task-sensor
branch
from
5b03461 to
a9fcc58
Compare
Contributor
Author
Thanks good point. Reverted but can't untag the extra reviewers it pinged. Sorry all! |
vincbeck
reviewed
Jul 28, 2025
providers/amazon/src/airflow/providers/amazon/aws/sensors/mwaa.py
Outdated
Show resolved
Hide resolved
vincbeck
approved these changes
Jul 30, 2025
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
LGTM, some mypy failures to take care of though
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Aug 5, 2025
* Add MwaaTaskSensor to Amazon Provider Package * include pre-commit hooks * - Comply with PR apache#51196: explicitly pass to its superclass, and adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress. * documentation update * Response to PR apache#51719 comments - Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding. * update tests * Remove duplicate pointer to mwaatasksensor docs * merge apache#53000 * Fix integration tests * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * remove State file from PR * Remove hard coding deferrable property * Remove unnecessary execute_complete function in sensor and instead use end_from_trigger * Correctly use end_from_trigger attribute * Correctly use end_from_trigger attibute for both dag run sensor and task sensor * Remove unnecessary import
40 tasks
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
* Add MwaaTaskSensor to Amazon Provider Package * include pre-commit hooks * - Comply with PR apache#51196: explicitly pass to its superclass, and adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress. * documentation update * Response to PR apache#51719 comments - Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding. * update tests * Remove duplicate pointer to mwaatasksensor docs * merge apache#53000 * Fix integration tests * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * remove State file from PR * Remove hard coding deferrable property * Remove unnecessary execute_complete function in sensor and instead use end_from_trigger * Correctly use end_from_trigger attribute * Correctly use end_from_trigger attibute for both dag run sensor and task sensor * Remove unnecessary import
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
* Add MwaaTaskSensor to Amazon Provider Package * include pre-commit hooks * - Comply with PR apache#51196: explicitly pass to its superclass, and adjust the default value of in base class to . - Add defensive test around adding more task instance states to keep of the MwaaTaskCompletedTrigger up to date. - Fix issue where of the MwaaTaskSensor derives to instead of type. - Modify documentation to clearly indicate that the MwaaTaskSensor is meant to sense tasks across different MWAA environments. - Make an optional parameter, where it defaults to the latest dag run. - Externally fetch the task ID variable. - Test the sensor while a DAG Run is still in progress. * documentation update * Response to PR apache#51719 comments - Brought UPSTREAM_FAILED to a Terminal Task Instance State instead of an Intermediate State. - Added REMOVED to the list of successful terminal task instance states. - Iterate programmatically through successful, failure, and in progress states instead of hard-coding. * update tests * Remove duplicate pointer to mwaatasksensor docs * merge apache#53000 * Fix integration tests * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * removed unnecessary defensive tests for trigger acceptor states after apache#53000 merge * remove State file from PR * Remove hard coding deferrable property * Remove unnecessary execute_complete function in sensor and instead use end_from_trigger * Correctly use end_from_trigger attribute * Correctly use end_from_trigger attibute for both dag run sensor and task sensor * Remove unnecessary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MwaaTaskSensorwaits for the completion of a DAG task instance in an MWAA environment. This PR includes an implementation with unit tests, system tests, and docs. Similar to MwaaDagRunSensorAlso modified system test to have
MwaaTriggerDagRunOperatorset todeferrable=True. This tests theMwaaTaskSensorandMwaaDagRunSensorsensors during execution of DAG Run rather than only afterwards.