Enable extra_options even when extra not defined for HttpHook.run #51746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinDruzhinin
force-pushed
the
fix-51685
branch
from
c61e072 to
c86e064
Compare
jroachgolf84
approved these changes
Jun 16, 2025
Collaborator
jroachgolf84
left a comment
jroachgolf84
left a comment
There was a problem hiding this comment.
Nice changes, and good catch! My approval holds no weight, but it looks good to me. I am going to wait until this is merged to begin by work on #51686, unless you are interested in integrating that into these changes.
potiuk
approved these changes
Jun 16, 2025
Member
|
Nice one! @jroachgolf84 -> merged. |
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
…ache#51746) Co-authored-by: Valentyn Druzhynin <v.druzhynin@zakaz.global>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #51685