Move MESSAGE_QUEUE_PROVIDERS array to where it belongs - to msq_queue #51774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
backport-to-v3-1-test
potiuk
removed
the
backport-to-v3-1-test
1 task
The MESSAGE_QUEUE_PROVIDERS array was defined in the `__init__.py` of the provider and it was pretty wrong because it was evaluated when the provider was imported - so it was impossible to import the base provider without initializing the arraym which caused circular import. Fixes: apache#51770
potiuk
force-pushed
the
fix-sqs-queue-import
branch
from
ab30f66 to
fce3b2c
Compare
eladkal
approved these changes
Jun 16, 2025
9 tasks
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
…apache#51774) The MESSAGE_QUEUE_PROVIDERS array was defined in the `__init__.py` of the provider and it was pretty wrong because it was evaluated when the provider was imported - so it was impossible to import the base provider without initializing the arraym which caused circular import. Fixes: apache#51770
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 5, 2025
The apache#51774 changed the important way how intialization is done, it was causing circular imports in case it was imported directly. This PR changes minimum version of common messaging for all providers using it and generally for core airflow.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 6, 2025
The apache#51774 changed the important way how intialization is done, it was causing circular imports in case it was imported directly. This PR changes minimum version of common messaging for all providers using it and generally for core airflow.
potiuk
added a commit
that referenced
this pull request
Aug 6, 2025
The #51774 changed the important way how intialization is done, it was causing circular imports in case it was imported directly. This PR changes minimum version of common messaging for all providers using it and generally for core airflow.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 6, 2025
The apache#51774 changed the important way how intialization is done, it was causing circular imports in case it was imported directly. This PR changes minimum version of common messaging for all providers using it and generally for core airflow. (cherry picked from commit 9cc0717)
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
The apache#51774 changed the important way how intialization is done, it was causing circular imports in case it was imported directly. This PR changes minimum version of common messaging for all providers using it and generally for core airflow.
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MESSAGE_QUEUE_PROVIDERS array was defined in the
__init__.pyof the provider and it was pretty wrong because it was evaluated when the provider was imported - so it was impossible to import the base provider without initializing the arraym which caused circular import.Fixes: #51770
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.