-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Use merged to render airflow.cfg and include computed defaults #51828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use merged to render airflow.cfg and include computed defaults #51828
Conversation
|
changes looks good. |
|
@romsharon98 Thanks for the tip about regression. If in the future additional defaults are applied, they will be separately tested. |
Just wondering how it's passing before the change.. |
…soha/airflow into feature/helm-use-merged-config-values
|
Because I made a few changes to the code:
|
Thanks for the clarification:) |
Ensures that
airflow.cfgis rendered from the merged configuration object ($config) instead of.Values.config, allowing computed default values likeexecution_api_server_urlto be properly included in the final config.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.