-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Reorganize docs tests for task-sdk into task-sdk/tests/docs #51876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8f5dc4f to
43967ed
Compare
|
I would even propose to turn them into scripts and run them via pre-commit. Those tests are fast and can be easily run every time "task-sdk" changes and they are much more like "static" tests than "unit tests" |
|
You don't even have to add it to "scripts/ci/pre-commit" -> you can easily run them directly from here. |
@potiuk These public‐api checks are true pytest tests - they import the package at runtime, inspect all, and assert what’s actually there. I think pre-commit hooks in Airflow are intended to be fast, static linters or formatters, and they shouldn’t be reaching into the code to execute it. |
cbd066c to
4609e3c
Compare
|
Ah yeah - I see they run "sphinx-build"... BTW. Why not making it as sphinx extension instead? We have also a number of sphinx extensions that are run during the build of documentation and it means that they are running as part of "doc build" phase automatically. |
4609e3c to
df6ebc2
Compare
df6ebc2 to
0ae0f17
Compare
@potiuk I can take as part of next PR. |
Yep. Not needed now :). Just something to consider. |
This is follow up PR based on this comment #51153 (comment)
This PR refactors our tests for task-sdk by moving all docs-related tests into a dedicated docs directory.
related: #51519
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.