Skip to content

Fix Task Instance “No Status” Filter #51880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 5 commits into from
Jun 24, 2025
Merged

Fix Task Instance “No Status” Filter #51880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4184da1
Support no_status alias in TaskInstance state filter for REST API
sunank200 Jun 18, 2025
319a4da
Allow 'no_status' state filter and include no_status in valid state l…
sunank200 Jun 19, 2025
600f805
Fix NULL-state filtering in get_mapped_task_instances by coalescing d…
sunank200 Jun 23, 2025
5a748a0
Refactor datetime_range_filter_factory: coalesce only start_date and …
sunank200 Jun 23, 2025
1d7b568
Add a test
sunank200 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions airflow-core/src/airflow/api_fastapi/common/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
from fastapi import Depends, HTTPException, Query, status
from pendulum.parsing.exceptions import ParserError
from pydantic import AfterValidator, BaseModel, NonNegativeInt
from sqlalchemy import Column, and_, case, or_
from sqlalchemy import Column, and_, case, func, or_
from sqlalchemy.inspection import inspect

from airflow.api_fastapi.core_api.base import OrmClause
Expand Down Expand Up @@ -493,9 +493,12 @@ def depends_datetime(
lower_bound: datetime | None = Query(alias=f"{filter_name}_gte", default=None),
upper_bound: datetime | None = Query(alias=f"{filter_name}_lte", default=None),
) -> RangeFilter:
attr = getattr(model, attribute_name or filter_name)
if filter_name in ("start_date", "end_date"):
attr = func.coalesce(attr, func.now())
return RangeFilter(
Range(lower_bound=lower_bound, upper_bound=upper_bound),
getattr(model, attribute_name or filter_name),
attr,
)

return depends_datetime
Expand Down Expand Up @@ -610,7 +613,7 @@ def _transform_ti_states(states: list[str] | None) -> list[TaskInstanceState | N
return None

try:
return [None if s in ("none", None) else TaskInstanceState(s) for s in states]
return [None if s in ("no_status", "none", None) else TaskInstanceState(s) for s in states]
except ValueError:
raise HTTPException(
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
Expand Down
21 changes: 21 additions & 0 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,6 +964,19 @@ class TestGetTaskInstances(TestTaskInstanceEndpoint):
3,
id="test state filter",
),
pytest.param(
[
{"state": State.RUNNING},
{"state": State.QUEUED},
{"state": State.SUCCESS},
{"state": State.NONE},
],
False,
("/dags/example_python_operator/dagRuns/TEST_DAG_RUN_ID/taskInstances"),
{"state": ["no_status"]},
1,
id="test no_status state filter",
),
pytest.param(
[
{"state": State.NONE},
Expand All @@ -977,6 +990,14 @@ class TestGetTaskInstances(TestTaskInstanceEndpoint):
4,
id="test null states with no filter",
),
pytest.param(
[{"start_date": None, "end_date": None}],
True,
"/dags/example_python_operator/dagRuns/TEST_DAG_RUN_ID/taskInstances",
{"start_date_gte": DEFAULT_DATETIME_STR_1},
1,
id="test start_date coalesce with null",
),
pytest.param(
[
{"pool": "test_pool_1"},
Expand Down