[v2-11-test] Stop streaming task logs if end of log mark is missing #51904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, somehow, the end of log mark can be missing, and when that happens the streaming log reader enters an infinite loop. Instead, if the task is in a non-running state and we stop receiving log lines but never get the end of log mark, we assume we won't and stop trying. We do tell emit that we are stopping though.
Member
|
Nice... But tests failing... Some of them seem to be coming from the chnge ( I think there are few to fix in the branch though) |
shahar1
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, somehow, the end of log mark can be missing, and when that
happens the streaming log reader enters an infinite loop. Instead, if
the task is in a non-running state and we stop receiving log lines but
never get the end of log mark, we assume we won't and stop trying. We do
tell emit that we are stopping though.
Backport of #50715.