Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

While working on #51930, realised another thing: we define login as "str | None" and define those as str for DBT cloud connection type. If that's the case, the connection can never be converted to a uri and fails like so:

ERROR providers/dbt/cloud/tests/unit/dbt/cloud/hooks/test_dbt.py::TestDbtCloudHook::test_trigger_job_run_with_retry_from_failure[get_job_runs_data1-False-explicit_account] - TypeError: quote_from_bytes() expected bytes

Hence, instead of modifying the login type in connection model, we should convert that to string while creating the DBT connections. A later follow up can be actually taking input as a string in the hook.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@amoghrajesh amoghrajesh merged commit 067b3e8 into apache:main Jun 20, 2025
69 checks passed
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants