Remove FAB dependency from Edge3 Provider #51995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:edge
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Flask AppBuilder (FAB) dependency from the Edge3 provider plugin by loading UI/auth code only for Airflow 2.x and using FastAPI apps for Airflow 3.x.
- Refactors
EdgeExecutorPluginto conditionally import and register endpoints based onAIRFLOW_V_3_0_PLUS. - Updates unit tests to assert the new plugin attributes across Airflow versions.
- Cleans up
pyproject.tomlby dropping the FAB provider dependency.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| providers/edge3/tests/unit/edge3/plugins/test_edge_executor_plugin.py | Adjusted assertions & added skip for Airflow 3+ behavior |
| providers/edge3/src/airflow/providers/edge3/plugins/edge_executor_plugin.py | Wrapped UI code in version checks and removed old FAB logic |
| providers/edge3/pyproject.toml | Removed apache-airflow-providers-fab from dependencies |
providers/edge3/src/airflow/providers/edge3/plugins/edge_executor_plugin.py
Show resolved
Hide resolved
providers/edge3/src/airflow/providers/edge3/plugins/edge_executor_plugin.py
Show resolved
Hide resolved
potiuk
approved these changes
Jun 21, 2025
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 21, 2025
This reverts commit 6931f3a.
potiuk
added a commit
that referenced
this pull request
Jun 21, 2025
jscheffl
added a commit
that referenced
this pull request
Jun 21, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
* Remove FAB dependency from Edge3 Provider * Uuups, pytests needed adjustment
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
…ache#51998) This reverts commit 6931f3a.
jscheffl
added a commit
that referenced
this pull request
Jun 21, 2025
jscheffl
added a commit
that referenced
this pull request
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards of support of Python 3.13 we see that edge3 provider needs to be excluded for the moment as FAB is not ready for Python 3.13. See #46891
FAB dependency was only used in the Plugin for the UI which anyway is limited to Airflow 2.x atm as plugin support in Airflow 3 UI is still WIP.
This PR reworks the logic in the UI Plugin such that the FAB dependency is removed - in Airflow 2.x this was belonging into the core and only for Airflow 3 the auth manager stuff was moved to FAB... so actually the dependency in the provider is not needed.
The change looks big but actually it is just moving existing code into conditional blocks such that auth manager code is only needed in Airflow 2 and Airflow 3 Plugin code now loads only API server backend needed.
@potiuk Can you be my reviewer for the change?
Tested it manually with breeze on 2.11.0, 3.0.2 and main - all still working.