Include fixed navbar for anchor position calculation in docs. #52016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jun 22, 2025
Member
|
nice. We need to improve the workflow (or at least documentation) for site layout changes. CC: as discussed recently @mik-laj ! |
Contributor
Author
|
@potiuk was this deployed? I still see the problem. |
Member
|
Not really - it needs to be cherry-picked I think to 3-0-test, because we build documentation from there. |
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Jul 21, 2025
…ache#52016) (cherry picked from commit d8086e6) Co-authored-by: Josef Šimánek <josef.simanek@gmail.com>
potiuk
added a commit
that referenced
this pull request
Jul 21, 2025
Member
|
Cherry-picked here: #53581 |
Member
|
Let me try to rebuild the site and see :) |
Member
|
OK. there is just one clarification added in 3.0.3 branch - so I can safely rebuild the docs. Let me try. |
Member
|
Ach .. not that easy... Have to fix an error in our workflow :) |
Member
|
PR to fix the workflow here: #53582 |
Contributor
Author
|
Good luck 🙏. |
Member
|
Seems it works on staging. Rebuilding it on live site. |
Member
|
Nice... It works ! Thank you! I miseed we needed to deploy it :) |
Contributor
Author
|
I can confirm, all good on my side. 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During work on some docs changes, I have noticed anchor links are partially broken, since they scroll to content hidden behind navbar.
currently navigating to https://airflow.apache.org/docs/apache-airflow/stable/index.html#workflows-as-code shows
with this fix, it scrolls properly
I have fixed also missing top padding (due to banner). I wasn't able to find out logic behind loading the banner, but it is fixed 40px in all viewports (seems so). I have added it whenever needed for calculations and made clear comments on what's happening. In case of banner is removed, those number should be recalculated, there is probably no simple automated way currently to do that.
This whole problem could be fixed also by making content own scroll context (instead of fixed navbar), but it will involve a lot of layout changes I'm not brave enough to provide (I wasn't able to find out even basic layout setup). This fixes the problem with minimal code changes.