Skip to content

Conversation

@dominikhei
Copy link
Contributor

@dominikhei dominikhei commented Jun 22, 2025


This PR is part of #52020 and removes pytest.mark_db_test where possible from the docker provider tests

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. one NIT

@dominikhei
Copy link
Contributor Author

Nice. one NIT

Wait error from my side -> Accidentally added docker to the hook - even though it has some @pytest.mark.db_test left, will remove! But why did it pass?

@potiuk
Copy link
Member

potiuk commented Jun 22, 2025

It was

Nice. one NIT

Wait error from my side -> Accidentally added docker to the hook - even though it has some @pytest.mark.db_test left, will remove! But why did it pass?

It did not pass :) - see the red cross :)

@potiuk potiuk merged commit 62d5be9 into apache:main Jun 22, 2025
67 checks passed
@dominikhei
Copy link
Contributor Author

It was

Nice. one NIT

Wait error from my side -> Accidentally added docker to the hook - even though it has some @pytest.mark.db_test left, will remove! But why did it pass?

It did not pass :) - see the red cross :)

I mean locally on my machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants