Skip to content

Clean DB Test flag from SMTP where Connection is used #52029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jun 22, 2025
Merged

Clean DB Test flag from SMTP where Connection is used #52029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions providers/smtp/tests/unit/smtp/hooks/test_smtp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@

from airflow.models import Connection
from airflow.providers.smtp.hooks.smtp import SmtpHook
from airflow.utils.session import create_session

pytestmark = pytest.mark.db_test


smtplib_string = "airflow.providers.smtp.hooks.smtp.smtplib"

Expand Down Expand Up @@ -317,8 +313,6 @@ def test_send_mime_noauth(self, mock_smtp, create_connection_without_db):
smtp_hook.send_email_smtp(to="to", subject="subject", html_content="content", from_email="from")
mock_smtp.assert_called_once_with(host="smtp_server_address", port=587, timeout=30)
assert not mock_smtp.login.called
with create_session() as session:
session.query(Connection).filter(Connection.id == conn.id).delete()

@patch("smtplib.SMTP_SSL")
@patch("smtplib.SMTP")
Expand Down