Skip to content

Conversation

@aritra24
Copy link
Collaborator

Part of: #52020


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
Copy link
Member

potiuk commented Jun 22, 2025

Apparently there are some db tests :)

@aritra24
Copy link
Collaborator Author

Yup, missed the right flags when testing locally :p Looking into it now

@aritra24 aritra24 marked this pull request as draft June 22, 2025 19:44
One test still remains `test_repo_url_access_missing_connection_doesnt_error`
which checks for non existance of connection, which doesn't
work due to the false check will hit the DB to access a session.
@aritra24
Copy link
Collaborator Author

@potiuk I think most of the tests are db less now, one remains which I think will have to stay due to it being a false check (ie, check for non-existence of connection)

@aritra24 aritra24 marked this pull request as ready for review June 22, 2025 20:14
@potiuk potiuk merged commit a3ebc3e into apache:main Jun 22, 2025
93 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants