Skip to content

Conversation

@choo121600
Copy link
Member

Part of #52020


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
Copy link
Member

potiuk commented Jun 22, 2025

Hmm.. Some testa are still failing :(

@choo121600 choo121600 force-pushed the remove-pytest/sqlite branch from 5893c42 to e71195f Compare June 23, 2025 05:49
@choo121600
Copy link
Member Author

I removed the pytestmark = pytest.mark.db_test marker.

However, since some tests still require a database connection, I kept @pytest.mark.db_test for those specific test functions.

Another change is the use of mock_connection with MagicMock. This was added to address the SQLAlchemy ORM initialization error that previously caused CI failures.

@potiuk
Copy link
Member

potiuk commented Jun 23, 2025

I removed the pytestmark = pytest.mark.db_test marker.

However, since some tests still require a database connection, I kept @pytest.mark.db_test for those specific test functions.

Another change is the use of mock_connection with MagicMock. This was added to address the SQLAlchemy ORM initialization error that previously caused CI failures.

Nice ! Thank you !

@potiuk potiuk merged commit ecab0fa into apache:main Jun 23, 2025
68 checks passed
@choo121600 choo121600 deleted the remove-pytest/sqlite branch June 24, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants