Skip to content

[v3-0-test] Add exception to context for task callbacks (#52055) #52066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Jun 23, 2025
Merged

[v3-0-test] Add exception to context for task callbacks (#52055) #52066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion task-sdk/src/airflow/sdk/execution_time/task_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,7 +1292,8 @@ def main():
bundle_name=ti.bundle_instance.name,
bundle_version=ti.bundle_instance.version,
):
state, msg, error = run(ti, context, log)
state, _, error = run(ti, context, log)
context["exception"] = error
finalize(ti, state, context, log, error)
except KeyboardInterrupt:
log = structlog.get_logger(logger_name="task")
Expand Down
11 changes: 9 additions & 2 deletions task-sdk/tests/task_sdk/execution_time/test_task_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2277,6 +2277,9 @@ def execute(self, context):

@pytest.mark.usefixtures("mock_supervisor_comms")
class TestTaskRunnerCallsCallbacks:
class _Failure(Exception):
"""Exception raised in a failed execution and received by the failure callback."""

def _execute_success(self, context):
self.results.append("execute success")

Expand All @@ -2288,7 +2291,7 @@ def _execute_skipped(self, context):

def _execute_failure(self, context):
self.results.append("execute failure")
raise Exception("sorry!")
raise self._Failure("sorry!")

@pytest.mark.parametrize(
"execute_impl, should_retry, expected_state, expected_results",
Expand Down Expand Up @@ -2336,6 +2339,10 @@ def test_task_runner_calls_callback(
def custom_callback(context, *, kind):
collected_results.append(f"on-{kind} callback")

def failure_callback(context):
custom_callback(context, kind="failure")
assert isinstance(context["exception"], self._Failure)

class CustomOperator(BaseOperator):
results = collected_results
execute = execute_impl
Expand All @@ -2345,7 +2352,7 @@ class CustomOperator(BaseOperator):
on_execute_callback=functools.partial(custom_callback, kind="execute"),
on_skipped_callback=functools.partial(custom_callback, kind="skipped"),
on_success_callback=functools.partial(custom_callback, kind="success"),
on_failure_callback=functools.partial(custom_callback, kind="failure"),
on_failure_callback=failure_callback,
on_retry_callback=functools.partial(custom_callback, kind="retry"),
)
runtime_ti = create_runtime_ti(dag_id="dag", task=task, should_retry=should_retry)
Expand Down