Add Pre-Commit Hook To Prevent Usage of session.query #52083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prab-27
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
Member
|
nice! |
Member
|
Som doc fixes? |
Member
|
Ah - looks intermittent. Will re-run when completed |
Member
|
re-run it |
potiuk
reviewed
Jun 23, 2025
Prab-27
force-pushed
the
add-pre-commit-to-prevent-usage-of-session-query
branch
from
75f58e2 to
8c66c73
Compare
potiuk
approved these changes
Jun 23, 2025
Member
|
Nice ! |
Contributor
Author
Sorry Wait I forgot to update the file name from pre-commit hook |
potiuk
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook checks usage of
session.query()sinceSQLAlchemy 2.0deprecates theQueryobjectRelated discussion .
Related PR : #47275
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.