Skip to content

fix: enable iframe script execution #52257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 4 commits into from
Jun 30, 2025
Merged

fix: enable iframe script execution #52257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4094bb
fix: enable iframe script execution
kevinhongzl Jun 25, 2025
f4227bf
fix: include vite env variables when transpiling typescripts
kevinhongzl Jun 27, 2025
aaa1d74
fix: add explanations to sandbox settings
kevinhongzl Jun 27, 2025
ad34055
fix: remove csp change
kevinhongzl Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airflow-core/src/airflow/ui/src/pages/Iframe.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,14 @@ export const Iframe = () => {
return <ErrorPage />;
}

// The following iframe sandbox setting is intentionally less restrictive.
// ONLY trusted contents can be framed within Iframe.
const sandbox = "allow-same-origin allow-forms";

return (
<Box flexGrow={1} m={-3}>
<iframe
sandbox="allow-same-origin allow-forms"
sandbox={sandbox}
src={iframeView.href}
style={{ height: "100%", width: "100%" }}
title={iframeView.name}
Expand Down
13 changes: 7 additions & 6 deletions airflow-core/src/airflow/ui/src/pages/Security.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,15 @@ export const Security = () => {
return <ErrorPage />;
}

// The following iframe sandbox setting is intentionally less restrictive.
// This is considered safe because the framed content originates from the Auth manager,
// which is part of the deployment of Airflow and trusted as per our security policy.
// https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html
const sandbox = "allow-scripts allow-same-origin allow-forms";

return (
<Box flexGrow={1} m={-3}>
<iframe
sandbox="allow-same-origin allow-forms"
src={link.href}
style={{ height: "100%", width: "100%" }}
title={link.text}
/>
<iframe sandbox={sandbox} src={link.href} style={{ height: "100%", width: "100%" }} title={link.text} />
</Box>
);
};
2 changes: 2 additions & 0 deletions scripts/ci/pre_commit/ts_compile_lint_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
all_non_yaml_files = [file for file in files if not file.endswith(".yaml")]
print("All non-YAML files:", all_non_yaml_files)
all_ts_files = [file for file in files if file.endswith(".ts") or file.endswith(".tsx")]
if all_ts_files:
all_ts_files.append("src/vite-env.d.ts")
print("All TypeScript files:", all_ts_files)

run_command(["pnpm", "config", "set", "store-dir", ".pnpm-store"], cwd=dir)
Expand Down