Skip to content

Remove side-effects in plugin manager tests #52258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 1 commit into from
Jun 25, 2025
Merged

Remove side-effects in plugin manager tests #52258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions airflow-core/tests/unit/plugins/test_plugins_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def on_load(self, *args, **kwargs):


@pytest.fixture(autouse=True, scope="module")
def clean_plugins():
def _clean_listeners():
get_listener_manager().clear()
yield
get_listener_manager().clear()
Expand Down Expand Up @@ -268,22 +268,20 @@ class MacroPlugin(AirflowPlugin):
def test_registering_plugin_listeners(self):
from airflow import plugins_manager

try:
with mock.patch("airflow.plugins_manager.plugins", []):
plugins_manager.load_plugins_from_plugin_directory()
plugins_manager.integrate_listener_plugins(get_listener_manager())

assert get_listener_manager().has_listeners
listeners = get_listener_manager().pm.get_plugins()
listener_names = [el.__name__ if inspect.ismodule(el) else qualname(el) for el in listeners]
# sort names as order of listeners is not guaranteed
assert sorted(listener_names) == [
"airflow.example_dags.plugins.event_listener",
"unit.listeners.class_listener.ClassBasedListener",
"unit.listeners.empty_listener",
]
finally:
get_listener_manager().clear()
assert not get_listener_manager().has_listeners
with mock.patch("airflow.plugins_manager.plugins", []):
plugins_manager.load_plugins_from_plugin_directory()
plugins_manager.integrate_listener_plugins(get_listener_manager())

assert get_listener_manager().has_listeners
listeners = get_listener_manager().pm.get_plugins()
listener_names = [el.__name__ if inspect.ismodule(el) else qualname(el) for el in listeners]
# sort names as order of listeners is not guaranteed
assert sorted(listener_names) == [
"airflow.example_dags.plugins.event_listener",
"unit.listeners.class_listener.ClassBasedListener",
"unit.listeners.empty_listener",
]

@skip_if_force_lowest_dependencies_marker
def test_should_import_plugin_from_providers(self):
Expand Down