Skip to content

Conversation

@albundy83
Copy link
Contributor

@albundy83 albundy83 commented Jun 25, 2025

closes: #52267

Should resolve warning:

/home/airflow/.local/lib/python3.12/site-packages/airflow/configuration.py:858 DeprecationWarning: The secret_key option in [webserver] has been moved to the secret_key option in [api] - the old setting has been used, but please update your config.

Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 25, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 25, 2025
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
@albundy83 albundy83 changed the title Add api secret_key for 3.0+ instead of webserver secret_key Use api secret_key for 3.0+ instead of webserver secret_key Jun 26, 2025
@albundy83 albundy83 changed the title Use api secret_key for 3.0+ instead of webserver secret_key Use api secret_key for airflow 3.0+ instead of webserver secret_key Jun 26, 2025
albundy83 and others added 2 commits June 26, 2025 22:47
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
albundy83 and others added 4 commits June 26, 2025 23:40
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
albundy83 and others added 2 commits June 27, 2025 23:19
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
@eladkal
Copy link
Contributor

eladkal commented Jun 30, 2025

tests are failing

@albundy83
Copy link
Contributor Author

tests are failing

Yes I see that.
I will try to understand why ...

albundy83 and others added 2 commits June 30, 2025 14:21
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
@albundy83
Copy link
Contributor Author

@eladkal maybe this one will fix, can you allow another tests please ?

albundy83 and others added 2 commits June 30, 2025 19:53
Signed-off-by: Grégoire Bellon-Gervais <gregoire.bellon-gervais@docaposte.fr>
@albundy83
Copy link
Contributor Author

Ok new commits :)
I have this one that I don't understand why it fails ...
If someone can help me to understand

@albundy83 albundy83 requested a review from jedcunningham July 1, 2025 20:32
@albundy83
Copy link
Contributor Author

My tests are now OK:

1459 passed, 3 warnings in 224.68s (0:03:44)

If someone can reapprove the workflow please :)

@albundy83
Copy link
Contributor Author

Finally tests are ok :)

@jedcunningham jedcunningham merged commit 45b9309 into apache:main Jul 3, 2025
70 checks passed
@eladkal eladkal added this to the Airflow Helm Chart 1.18.0 milestone Jul 3, 2025
@albundy83 albundy83 deleted the api_secret_key branch July 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing api secret_key capabilities to replace webserver for 3.0+

3 participants