[v3-0-test] Synchronize latest dev scripts with main #52293
Conversation
potiuk
requested review from
ashb,
gopidesupavan and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
force-pushed
the
backport-8846bef-v3-0-test
branch
from
9de8372 to
8a834a2
Compare
apache#52274) Due to the way how it historically got added - we had two ways of selecting whether we are installing airlfow dyanmically in breeze with or without constraints: * --install-airflow-with-constraints - was used in a few places * --skip-airflow-constraints - was used in other places The logic to handle those were broken at places where they contradicted each other. This PR unifies it and only uses the --install-airflow-with-constraints flag in all the places where we need to determine whether constraints are used or not and it fixes the logic. The logic of installation had been reviewed, refactored into separate methods doing smaller tasks and more diagnostics was added. (cherry picked from commit 8846bef) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
force-pushed
the
backport-8846bef-v3-0-test
branch
from
8a834a2 to
3c20e5c
Compare
potiuk
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
|
Changeset is much bigger than the original PR is that expected? |
Actually yes - because there were numerous conflicts and I realised that we have a number of non-cherry-picked PRs so instead (in order to avoid future conflicts and not having to cherry-pick all of them I simply synchronized with latest verison of the build scripts. Which means that I have to also change the description of the PR to explain it. But I think it's the right thing to do - because with the automated cherry-picks of dev scripts that will help to mininimse conflicts in those . |
potiuk
changed the title
|
I updated the description to reflect the scope. And when you compare the dev with main now - they are pretty much the same - with just a few differences. |
2 participants
This PR synchronizes latest dev scrips/ci wiht main. There were a number of PRs have not been cherry-picked, so now, when we automatically cherr-pick them, we can have conflicts (and often do). After we synchronize it, the conflcts should be rare and easy to solve (for example regenerating breeze images.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.