-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove Legacy Query Object Usage from airflow-models #52325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Legacy Query Object Usage from airflow-models #52325
Conversation
72b046a to
67e0627
Compare
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you help to make the CI green?
|
Converting into draft until green checks |
67e0627 to
bc302b0
Compare
airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated
Show resolved
Hide resolved
4910c67 to
bd99c84
Compare
airflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated
Show resolved
Hide resolved
335c872 to
34b3863
Compare
3fe6087 to
00158d5
Compare
98ed7a3 to
432672c
Compare
|
#protm Thank you again for your consistent work @Prab-27. |
|
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more! |
|
One remaining Query-related section—I'll address it soon |
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs
Updated methods like XComModel.get_many to return Select objects instead of Query objects
Adjusted dependent code to reflect the updated return types
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.