Skip to content

Conversation

@Prab-27
Copy link
Contributor

@Prab-27 Prab-27 commented Jun 27, 2025

Related discussion: here

This PR is part of the migration to SQLAlchemy 2.0

Replaced instances of session.query() with select() constructs
Updated methods like XComModel.get_many to return Select objects instead of Query objects
Adjusted dependent code to reflect the updated return types


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?

@Prab-27
Copy link
Contributor Author

Prab-27 commented Jun 30, 2025

Converting into draft until green checks

@Prab-27 Prab-27 marked this pull request as draft June 30, 2025 14:39
@Prab-27 Prab-27 force-pushed the remove-session-query-from-airflow-models branch from 67e0627 to bc302b0 Compare June 30, 2025 14:42
@Prab-27 Prab-27 force-pushed the remove-session-query-from-airflow-models branch from 4910c67 to bd99c84 Compare July 5, 2025 17:41
@Prab-27 Prab-27 force-pushed the remove-session-query-from-airflow-models branch 2 times, most recently from 335c872 to 34b3863 Compare July 21, 2025 17:10
@Prab-27 Prab-27 force-pushed the remove-session-query-from-airflow-models branch 4 times, most recently from 3fe6087 to 00158d5 Compare August 3, 2025 03:49
@Prab-27 Prab-27 force-pushed the remove-session-query-from-airflow-models branch from 98ed7a3 to 432672c Compare September 2, 2025 12:24
@uranusjr uranusjr merged commit 2357f96 into apache:main Sep 2, 2025
107 checks passed
@jason810496
Copy link
Member

#protm

Thank you again for your consistent work @Prab-27.

@Prab-27
Copy link
Contributor Author

Prab-27 commented Sep 3, 2025

Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!

@Prab-27
Copy link
Contributor Author

Prab-27 commented Sep 3, 2025

One remaining Query-related section—I'll address it soon

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants