Skip to content

Attempt2: Fix mypy in gcp generative_model #52331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Jun 27, 2025
Merged

Attempt2: Fix mypy in gcp generative_model #52331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ff7439
Attempt2: Fix mypy in gcp generative_model
gopidesupavan Jun 27, 2025
d99748a
Remove private class imports
gopidesupavan Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions providers/google/src/airflow/providers/google/cloud/hooks/vertex_ai/generative_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
from airflow.providers.google.common.hooks.base_google import PROVIDE_PROJECT_ID, GoogleBaseHook

if TYPE_CHECKING:
from google.cloud.aiplatform_v1 import types as types_v1
from google.cloud.aiplatform_v1beta1 import types as types_v1beta1


Expand All @@ -50,7 +49,7 @@ def get_text_embedding_model(self, pretrained_model: str):
def get_generative_model(
self,
pretrained_model: str,
system_instruction: str | None = None,
system_instruction: Any | None = None,
generation_config: dict | None = None,
safety_settings: dict | None = None,
tools: list | None = None,
Expand Down Expand Up @@ -82,7 +81,7 @@ def get_eval_task(
def get_cached_context_model(
self,
cached_content_name: str,
) -> preview_generative_model:
) -> Any:
"""Return a Generative Model with Cached Context."""
cached_content = CachedContent(cached_content_name=cached_content_name)

Expand Down Expand Up @@ -167,7 +166,7 @@ def supervised_fine_tuning_train(
adapter_size: Literal[1, 4, 8, 16] | None = None,
learning_rate_multiplier: float | None = None,
project_id: str = PROVIDE_PROJECT_ID,
) -> types_v1.TuningJob:
) -> Any:
"""
Use the Supervised Fine Tuning API to create a tuning job.

Expand Down Expand Up @@ -300,7 +299,7 @@ def create_cached_content(
model_name: str,
location: str,
ttl_hours: float = 1,
system_instruction: str | None = None,
system_instruction: Any | None = None,
contents: list[Any] | None = None,
display_name: str | None = None,
project_id: str = PROVIDE_PROJECT_ID,
Expand Down
2 changes: 1 addition & 1 deletion providers/google/src/airflow/providers/google/cloud/operators/vertex_ai/generative_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def __init__(
project_id: str,
location: str,
model_name: str,
system_instruction: str | None = None,
system_instruction: Any | None = None,
contents: list[Any] | None = None,
ttl_hours: float = 1,
display_name: str | None = None,
Expand Down