[v3-0-test] Improve dependency report and uppgrading (#52619) #52626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our dependencies should be set in "upgrade to newer dependencies" mode every time every single pyproject.toml changes - this is slower as it triggers full builds with all versions but it also prevents some errors when dependencies from one provider are impacting what will be resolved in the CI image. As part of it - whenever we run the dependency report with "source constraints" we use exactly the same `uv sync` command as used during image build with "ugprade to newer dependencies" - this way the report is more accurate as it includes some dependencies from dev dependency groups that have not been included in the current reports. (cherry picked from commit c489678) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our dependencies should be set in "upgrade to newer dependencies" mode every time every single pyproject.toml changes - this is slower as it triggers full builds with all versions but it also prevents some errors when dependencies from one provider are impacting what will be resolved in the CI image. As part of it - whenever we run the dependency report with "source constraints" we use exactly the same
uv synccommand as used during image build with "ugprade to newer dependencies" - this way the report is more accurate as it includes some dependencies from dev dependency groups that have not been included in the current reports.(cherry picked from commit c489678)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.