Skip to content

Conversation

@Dev-iL
Copy link
Collaborator

@Dev-iL Dev-iL commented Jul 1, 2025

Yet another part of #52233. Since airflow-core shouldn't depend on FAB, it might be possible to enable the associated CI workflow (🤞), and only introduce the equivalent workflow for providers after transitioning to FAB5.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copilot AI review requested due to automatic review settings July 1, 2025 15:23
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflows for airflow-core by enabling a special test for SQLAlchemy 2, which is part of the overall effort to separate FAB core dependencies from FAB and align with FAB5 transitions.

  • Adds a new "tests-latest-sqlalchemy" job to run SQLAlchemy tests in the core workflow.
  • Introduces a new workflow input "upgrade-sqlalchemy" to control the SQLAlchemy upgrade behavior.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/special-tests.yml Adds the new SQLAlchemy test job, configuring testing parameters for core.
.github/workflows/run-unit-tests.yml Adds the "upgrade-sqlalchemy" input and passes it through to the test jobs.

@Dev-iL Dev-iL force-pushed the Dev-iL/2507/enable_sqla2_core_ci branch from 12b088e to e6912d8 Compare July 1, 2025 15:53
@Dev-iL
Copy link
Collaborator Author

Dev-iL commented Jul 1, 2025

Closing since this approach doesn't work unfortunately.

@Dev-iL Dev-iL closed this Jul 1, 2025
@Dev-iL
Copy link
Collaborator Author

Dev-iL commented Jul 1, 2025

@potiuk Is there any simple way, e.g. via the combination of flags that exclude various tests, to make this workflow succeed?

@potiuk
Copy link
Member

potiuk commented Jul 1, 2025

@potiuk Is there any simple way, e.g. via the combination of flags that exclude various tests, to make this workflow succeed?

We could add an exception to that - but that would require some manual removal of packages and upgrade packages in entrypoint_ci.sh -> can you please open an issue for it and CC:,me? I understand what we need to do is to remove FAB and upgrade sqlalchemy to 2 and skip all the tests that depend on FAB.

This will be way easier after we merge #46891 as there we already have Py3.13 completely without fab and all the FAB-dependent tests are either moved out of core (when they were left) or modified to be skipped if fab is not installed - and I think we shoudl be able to merge it in a day or two - so if yoy can wait with that - that would be best.

@potiuk
Copy link
Member

potiuk commented Jul 18, 2025

OK. Merged now. I will take a look at creating the sqla2 job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants