Kill kube watcher instance if it doesnt terminate gracefully in 60 seconds #52662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavansharma36
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
kosteev
approved these changes
Jul 22, 2025
Contributor
kosteev
left a comment
kosteev
left a comment
There was a problem hiding this comment.
Hi Pavan, did you test this change end to end?
Can you, please, add also unit test for this.
Member
|
Yep. Would be great to get that in - seems that others have similar issue - @pavansharma36 ? |
kosteev
approved these changes
Jul 22, 2025
...cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
kosteev
approved these changes
Jul 28, 2025
Contributor
|
Can we submit this change? |
potiuk
approved these changes
Jul 30, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jul 31, 2025
…conds (apache#52662) * Kill kube watcher instance if it doesnt terminate gracefully in 60 seconds * suggested changes --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
40 tasks
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
…conds (apache#52662) * Kill kube watcher instance if it doesnt terminate gracefully in 60 seconds * suggested changes --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
…conds (apache#52662) * Kill kube watcher instance if it doesnt terminate gracefully in 60 seconds * suggested changes --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
|
Hi all, was that a bug or was it by design? And if it was a bug, has it been fixed? I am using Airflow version 2.10.4. Please let me know. |
Contributor
|
Fix was released in kubernetes provider v10.7.0 https://airflow.apache.org/docs/apache-airflow-providers-cncf-kubernetes/stable/changelog.html#id12 Its compaitible with airflow 3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #52284
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.