-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Test/sftp to wasb operator coverage #52688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/sftp to wasb operator coverage #52688
Conversation
| def dry_run(self) -> None: | ||
| if not AIRFLOW_V_3_0_PLUS: | ||
| raise NotImplementedError("Not implemented for Airflow 3.") | ||
| raise NotImplementedError("dry_run() is only supported in Airflow 3.0+.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this message is more clear than before. How about ur opinion?
f3a6d98 to
f3431ac
Compare
f3431ac to
9c6c4b5
Compare
d281a96 to
aa0cc88
Compare
|
I’m still getting used to how things work in open-source, so I wanted to ask: The PR is related to a recently merged one, so I thought it might make sense to get input from someone involved in that. and If no reviewer is assigned to a PR, is it okay to mention someone? Could you review my PR ? |
Better to just "remind" but not mention anyone. This will put it on the top and someone who is actually looking might have another chance not to overlook it. |
|
Unless someone already commented and you continue conversation of course. |
|
I just wanted to check — when you say "just remind", do you mean adding a comment without tagging anyone, like "Just a gentle reminder in case this was overlooked"? |
|
yes |
|
Generally - it's up to you as author to lead your PR to completion. But you have to be mindful that people here are volunteers - so you neded to figure out what's best on your own, that's the beauty and difficulty of being in opesource that in many cases this is all about humans and empathy and communication and you will not get ready recipes what to do. Eventually - use your own judgment what is best. And sometimes you will make mistakes and be corrected or reminded - but eventually - you are responsible to do what's good. |
|
Yes, I'm learning a lot from various aspects while contributing to open source. Thank you for your thoughtful advice. |
c1d0b05 to
c5aad32
Compare
|
@kaxil Thank you in advance for your time and support! |
c5aad32 to
93ceb94
Compare
93ceb94 to
9ae346b
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |

Related to
This PR addresses https://github.com/apache/airflow/issues/3190971584](https://github.com/apache/airflow/pull/52618) by adding missing unit tests for the
dry_run()method inSFTPToWasbOperator.What this PR adds
test_dry_run_logs_and_skips_real_actionVerifies that in Airflow 3+:
dry_run()logs the “Process will upload…” and “Executing delete…” messagesload_fileordelete_filecalls are madetest_dry_run_raises_not_implementedMocks
AIRFLOW_V_3_0_PLUS = Falseto simulate Airflow < 3.0, and asserts thatdry_run()raisesNotImplementedErrorwith the message:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.