Skip to content

[v3-0-test] Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult (#52673) #52691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 1 commit into from
Jul 2, 2025
Merged

[v3-0-test] Fix connection retrieval in triggerer for schema field, use by_alias=True for ConnectionResult (#52673) #52691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airflow-core/src/airflow/jobs/triggerer_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ def _handle_request(self, msg: ToTriggerSupervisor, log: FilteringBoundLogger, r
if isinstance(conn, ConnectionResponse):
conn_result = ConnectionResult.from_conn_response(conn)
resp = conn_result
dump_opts = {"exclude_unset": True}
# `by_alias=True` is used to convert the `schema` field to `schema_` in the Connection model
dump_opts = {"exclude_unset": True, "by_alias": True}
else:
resp = conn
elif isinstance(msg, GetVariable):
Expand Down
23 changes: 16 additions & 7 deletions airflow-core/tests/unit/jobs/test_triggerer_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,16 @@ async def test_trigger_can_access_variables_connections_and_xcoms(session, dag_m
task_instance.trigger_id = trigger_orm.id

# Create the appropriate Connection, Variable and XCom
connection = Connection(conn_id="test_connection", conn_type="http")
connection = Connection(
conn_id="test_connection",
conn_type="http",
schema="https",
login="user",
password="pass",
extra={"key": "value"},
port=443,
host="example.com",
)
variable = Variable(key="test_variable", val="some_variable_value")
XComModel.set(
key="test_xcom",
Expand Down Expand Up @@ -675,12 +684,12 @@ async def test_trigger_can_access_variables_connections_and_xcoms(session, dag_m
"conn_id": "test_connection",
"conn_type": "http",
"description": None,
"host": None,
"schema": None,
"login": None,
"password": None,
"port": None,
"extra": None,
"host": "example.com",
"schema": "https",
"login": "user",
"password": "pass",
"port": 443,
"extra": '{"key": "value"}',
},
"variable": "some_variable_value",
"xcom": '"some_xcom_value"',
Expand Down