Skip to content

Conversation

@sunank200
Copy link
Collaborator

Part of #52676


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@sunank200 sunank200 force-pushed the move-basehook-datadog branch from 8e4cc53 to cae02d0 Compare July 3, 2025 16:57
@amoghrajesh
Copy link
Contributor

I am investigating as to why redis tests are sometimes failing..

@potiuk
Copy link
Member

potiuk commented Jul 4, 2025

I am investigating as to why redis tests are sometimes failing..

Yeah. I saw that too

@potiuk
Copy link
Member

potiuk commented Jul 4, 2025

@xBis7 -> seems your latest change introduced some flakines in scenario in this "foreceful" stop test.

@xBis7
Copy link
Contributor

xBis7 commented Jul 4, 2025

@potiuk Can you determine approximately how ofter does the test fail? Is it too often? e.g. 50% of the runs?

I thought I fixed the flakiness because I was able to ran the CI at least 10 times without errors. I'll look into it.

@amoghrajesh
Copy link
Contributor

@xBis7 do not have exact numbers but I can share some occurrences with you that could help.

And few more, some of these have occurred more than once on the same pr. So it's not a one-off case, needs investigating and fixing

@xBis7
Copy link
Contributor

xBis7 commented Jul 5, 2025

I can see it as well, it has a 20% failure rate.

I'm investigating it. I might end up marking the tests with xfail until I come up with a permanent solution.

https://github.com/xBis7/airflow/actions/runs/16086980198

https://github.com/xBis7/airflow/actions/runs/16087424463

https://github.com/xBis7/airflow/actions/runs/16087596566

@potiuk
Copy link
Member

potiuk commented Jul 5, 2025

I can see it as well, it has a 20% failure rate.

I'm investigating it. I might end up marking the tests with xfail until I come up with a permanent solution.

Might be a good approach - if so -> create an issue and I wiil assign it to the "flaky stuff" board in CI / DEV ENV planned work

@xBis7
Copy link
Contributor

xBis7 commented Jul 5, 2025

#52906

@potiuk Can you modify it to add the correct labels?

@potiuk
Copy link
Member

potiuk commented Jul 5, 2025

@potiuk Can you modify it to add the correct labels?

Done.

@xBis7
Copy link
Contributor

xBis7 commented Jul 5, 2025

Done.

Thanks!

@amoghrajesh amoghrajesh merged commit 244cc67 into apache:main Jul 6, 2025
71 checks passed
@amoghrajesh amoghrajesh deleted the move-basehook-datadog branch July 6, 2025 15:31
HsiuChuanHsu pushed a commit to HsiuChuanHsu/airflow that referenced this pull request Jul 10, 2025
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
stephen-bracken pushed a commit to stephen-bracken/airflow that referenced this pull request Jul 15, 2025
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants