-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Move all BaseHook usages to version_compat in Datadog #52801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e4cc53 to
cae02d0
Compare
|
I am investigating as to why redis tests are sometimes failing.. |
Yeah. I saw that too |
|
@xBis7 -> seems your latest change introduced some flakines in scenario in this "foreceful" stop test. |
|
@potiuk Can you determine approximately how ofter does the test fail? Is it too often? e.g. 50% of the runs? I thought I fixed the flakiness because I was able to ran the CI at least 10 times without errors. I'll look into it. |
|
@xBis7 do not have exact numbers but I can share some occurrences with you that could help.
And few more, some of these have occurred more than once on the same pr. So it's not a one-off case, needs investigating and fixing |
|
I can see it as well, it has a 20% failure rate. I'm investigating it. I might end up marking the tests with https://github.com/xBis7/airflow/actions/runs/16086980198 https://github.com/xBis7/airflow/actions/runs/16087424463 https://github.com/xBis7/airflow/actions/runs/16087596566 |
Might be a good approach - if so -> create an issue and I wiil assign it to the "flaky stuff" board in CI / DEV ENV planned work |
Done. |
Thanks! |
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Part of #52676
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.