Skip to content

Conversation

@gopidesupavan
Copy link
Member

We have fixed integration test discovery to discover only provided integration, here #52462 , I have missed updating env vars casuing the tests skipping 😞

This fixes them now.

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@gopidesupavan gopidesupavan requested review from ashb and potiuk as code owners July 3, 2025 18:54
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 3, 2025
@gopidesupavan
Copy link
Member Author

cc: @ahmadtfarhan

@potiuk
Copy link
Member

potiuk commented Jul 3, 2025

Yeah. We changed it recently .. and not fully. I also prefer to keep consistency with "provider" name rather than with "tested" thingie (even though technically this is integration with gremlin -but we are "integration-testing" tinkerpop provider so INTEGRATION_TINKERPOP seems more appropriate and easier to fit-in our automation as we derive few things with integration name (path, name of marker etc.).

@potiuk potiuk merged commit 53cb9f0 into apache:main Jul 3, 2025
104 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 3, 2025
…iable name (#52826)

(cherry picked from commit 53cb9f0)

Co-authored-by: GPK <gopidesupavan@gmail.com>
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 3, 2025
…iable name (apache#52826)

(cherry picked from commit 53cb9f0)

Co-authored-by: GPK <gopidesupavan@gmail.com>
@ahmadtfarhan
Copy link
Contributor

Yeah. We changed it recently .. and not fully. I also prefer to keep consistency with "provider" name rather than with "tested" thingie (even though technically this is integration with gremlin -but we are "integration-testing" tinkerpop provider so INTEGRATION_TINKERPOP seems more appropriate and easier to fit-in our automation as we derive few things with integration name (path, name of marker etc.).

Totally agree! I just never had the time to do the change.
Thanks both for the changes

potiuk pushed a commit that referenced this pull request Jul 3, 2025
…iable name (#52826) (#52830)

(cherry picked from commit 53cb9f0)

Co-authored-by: GPK <gopidesupavan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants