Fix Confirmation dialog for DagRun MarkAs and Clear Actions

[punx120]

---

This fixes #51966. When clicking to mark a run as success or failed, the confirmation dialog was never shown. Kegboard shortcut are actually working correctly.

It's my first using typescript, this fixes the behavior, but i wonder if it would not be better to follow the pattern in ClearRun.tsx, at least for the sake of consistency?

Also, i'm doing this PR against v2-11-stable which is probably incorrect?

[pierrejeambrun]

Also, i'm doing this PR against v2-11-stable which is probably incorrect?

This is correct, it is the latest v2-x release branch.

it's my first using typescript, this fixes the behavior, but i wonder if it would not be better to follow the pattern in ClearRun.tsx, at least for the sake of consistency?

The patterns are exactly similar, the only difference is that we use a useReducer to manager the more complex states.

And therefore there is the exact same problem with clearing a Run, can you also fix that please ?

[pierrejeambrun]

Unrelated but it's weird because for TaskInstance there isn't the ability to "skip confirmation modal".

[punx120]

And therefore there is the exact same problem with clearing a Run, can you also fix that please ?

Indeed, fixed

[punx120]

Unrelated but it's weird because for TaskInstance there isn't the ability to "skip confirmation modal".

It may be related to the fact that there are various options that user can choose from, and it may not make sense to always use the same ones.

[pierrejeambrun]

Thanks for the fix.

Code looks good, working as expected

[punx120]

Is there a planned release for 2.11.1 or 2.12 ?

[potiuk]

Is there a planned release for 2.11.1 or 2.12 ?

No 2.12, only critical / secuirty fixes in 2.11.* - and yes it's planned when we get some security related dependencies unblocked - no time when it might happen, because a lot of that is outside of our hands. But watch for devlist announcements when we will call people to test it.

In the meantime, If you want - you can cherry-pick any changes fro v2-11-stable, v2-11-test branches and build your own airflow package or even patch your running airflow instance - that would also help if we get the early confirmation from users like you that those fixes work.