Skip to content

Conversation

@vmtuan12
Copy link
Contributor

@vmtuan12 vmtuan12 commented Jul 4, 2025

Add debug logging when endpoint_url is missing in extra config of AWS Connection. This helps user identify the problem easier, as described in #52697


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jul 4, 2025
@vmtuan12 vmtuan12 force-pushed the chore/debug-aws-provider-endpoint branch from 5290596 to 4b6a84c Compare July 4, 2025 10:04
@vmtuan12 vmtuan12 force-pushed the chore/debug-aws-provider-endpoint branch from 4b6a84c to 3744d00 Compare July 4, 2025 12:13
@potiuk
Copy link
Member

potiuk commented Jul 4, 2025

redis is flaky and we want to fix it soon

@potiuk potiuk merged commit 2ef586e into apache:main Jul 4, 2025
72 of 73 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 4, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants