Fix task configuration defaults for AbstractOperator #52871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
XD-DENG,
amoghrajesh,
ashb,
jscheffl and
uranusjr
as code owners
boring-cyborg
bot
added
area:providers
area:task-sdk
provider:edge
kaxil
added
the
backport-to-v3-1-test
amoghrajesh
approved these changes
Jul 4, 2025
ashb
reviewed
Jul 4, 2025
ashb
approved these changes
Jul 4, 2025
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Looks like you are also missing
- default_task_retry_delay
- default_task_retries
- default_task_weight_rule
- default_queue
Member
Author
aah, yeah will fix them in this PR itself so it is all in one |
hussein-awala
approved these changes
Jul 4, 2025
kaxil
force-pushed
the
remove-abstract-operator
branch
4 times, most recently
from
bb51a52 to
139c058
Compare
Some defaults weren't being taken from configuration -- this is now fixed.
kaxil
force-pushed
the
remove-abstract-operator
branch
from
139c058 to
dcedeff
Compare
Member
Author
|
Static checks fixed by #52887 |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 04d2d3b v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
2 tasks
2 tasks
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 11, 2025
Some defaults weren't being taken from configuration -- this is now fixed. (cherry picked from commit 04d2d3b)
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 11, 2025
Some defaults weren't being taken from configuration -- this is now fixed. (cherry picked from commit 04d2d3b)
kaxil
added a commit
that referenced
this pull request
Aug 11, 2025
Some defaults weren't being taken from configuration -- this is now fixed. (cherry picked from commit 04d2d3b)
This was referenced Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some defaults weren't being taken from configuration -- this is now fixed.
Simple Test to ensure back-compat works:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.