-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Revert "Build python from source for CI (#52265)" #52900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit d06a27e.
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked in detail but if its breaking things, lets revert.
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker e463ed1 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
@amoghrajesh The problem was that in my review I completely forgot that we need to handle also all other versions of Python :) . So insted of just "3.10.18" we should keep a dictionary of all patchlevels in all latest versions and pass the right patchlevel from that dictionally when you run for example:
And we completely missed it. And we have not run But I spoke to @aritra24 and he will redo that part. |
|
I only realized it when I cherry-picked it to |
|
🤦 from my side |
|
oo even i forgot that check 😞 |
This reverts commit d06a27e.
This reverts commit d06a27e.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.