Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 5, 2025

This reverts commit d06a27e.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk requested review from ashb and gopidesupavan as code owners July 5, 2025 08:24
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 5, 2025
@potiuk potiuk requested review from amoghrajesh and aritra24 and removed request for ashb and gopidesupavan July 5, 2025 08:24
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked in detail but if its breaking things, lets revert.

@potiuk potiuk merged commit e463ed1 into apache:main Jul 5, 2025
87 checks passed
@potiuk potiuk deleted the revert-building-from-sources branch July 5, 2025 08:32
@github-actions
Copy link

github-actions bot commented Jul 5, 2025

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker e463ed1 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@potiuk
Copy link
Member Author

potiuk commented Jul 5, 2025

@amoghrajesh The problem was that in my review I completely forgot that we need to handle also all other versions of Python :) . So insted of just "3.10.18" we should keep a dictionary of all patchlevels in all latest versions and pass the right patchlevel from that dictionally when you run for example:

breeze ci-image build --python 3.12 -> should result in AIRFLOW_PYTHON_VERSION=3.12.11

And we completely missed it. And we have not run all versions tests - but what this one would eventually do is ... all the images would be 3.10.18 even if we tried to build 3.12 - that was my mistake, I completely missed it during the review :D

But I spoke to @aritra24 and he will redo that part.

@potiuk
Copy link
Member Author

potiuk commented Jul 5, 2025

I only realized it when I cherry-picked it to v3-0-test and was a bit surprised to see Python 3.10 image being built .... :D

@potiuk
Copy link
Member Author

potiuk commented Jul 5, 2025

🤦 from my side

@gopidesupavan
Copy link
Member

oo even i forgot that check 😞

HsiuChuanHsu pushed a commit to HsiuChuanHsu/airflow that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants