Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

A slightly advanced auto classification ability to the current preparation of provider documentation.

If files were changed across providers like in the case of https://github.com/apache/airflow/pull/52017/files, the classification got confused and returned "other". It should only consider the current provider and classify on that always.

Adding ability to do that, check these test cases for detail: https://github.com/apache/airflow/compare/main...amoghrajesh:airflow:advanced-classification-providers?expand=1#diff-f454c189159243e617baf7c442df3dc8f7bff5a3e581d9ba0e941c4434fd0b0cR447-R463

It classifies only for respective providers!


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@amoghrajesh amoghrajesh requested a review from eladkal July 5, 2025 09:46
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 5, 2025
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

When are you going to plug-in Gen-AI to do the classification ???? Should be no brainer :)

@potiuk potiuk merged commit 1996171 into apache:main Jul 5, 2025
102 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 5, 2025
…52902)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@github-actions
Copy link

github-actions bot commented Jul 5, 2025

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

potiuk pushed a commit that referenced this pull request Jul 5, 2025
…52902)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 5, 2025
…pache#52902)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
potiuk pushed a commit that referenced this pull request Jul 5, 2025
…52902) (#52925)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
kaxil pushed a commit that referenced this pull request Jul 7, 2025
…52902) (#52925)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
kaxil pushed a commit that referenced this pull request Jul 7, 2025
…52902) (#52925)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
kaxil pushed a commit that referenced this pull request Jul 9, 2025
…52902) (#52925)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
HsiuChuanHsu pushed a commit to HsiuChuanHsu/airflow that referenced this pull request Jul 10, 2025
kaxil pushed a commit that referenced this pull request Jul 11, 2025
…52902) (#52925)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
kaxil pushed a commit that referenced this pull request Jul 11, 2025
…52902) (#52925)

(cherry picked from commit 1996171)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
stephen-bracken pushed a commit to stephen-bracken/airflow that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants