-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Advanced auto classification for provider documentation #52902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 3 commits into
apache:main
from
amoghrajesh:advanced-classification-providers
Jul 5, 2025
Merged
Advanced auto classification for provider documentation #52902
potiuk
merged 3 commits into
apache:main
from
amoghrajesh:advanced-classification-providers
Jul 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Jul 5, 2025
Contributor
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
potiuk
approved these changes
Jul 5, 2025
Member
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
When are you going to plug-in Gen-AI to do the classification ???? Should be no brainer :)
gopidesupavan
approved these changes
Jul 5, 2025
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 5, 2025
…pache#52902) (cherry picked from commit 1996171) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
Jul 5, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 7, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 7, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 9, 2025
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Jul 10, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 11, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 11, 2025
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly advanced auto classification ability to the current preparation of provider documentation.
If files were changed across providers like in the case of https://github.com/apache/airflow/pull/52017/files, the classification got confused and returned "other". It should only consider the current provider and classify on that always.
Adding ability to do that, check these test cases for detail: https://github.com/apache/airflow/compare/main...amoghrajesh:airflow:advanced-classification-providers?expand=1#diff-f454c189159243e617baf7c442df3dc8f7bff5a3e581d9ba0e941c4434fd0b0cR447-R463
It classifies only for respective providers!
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.