[v3-0-test] Exclude "openapi.merged.json" from built .sdist and .whl distributions (#52908) #52910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…distributions (#52908) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example. (cherry picked from commit 93f2bcc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil
pushed a commit
that referenced
this pull request
Jul 7, 2025
…distributions (#52908) (#52910) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example. (cherry picked from commit 93f2bcc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file might be a left-over from earlier api generation and it is
already .gitignored, so it does not appear in the source tarball,
but sdist and wheel generation does not look at .gitignored files
(for a good reason - we might want to include some generated files
in those distributions) - so we should exclude it manually similarly
as we already do with node_modules for example.
(cherry picked from commit 93f2bcc)
Co-authored-by: Jarek Potiuk jarek@potiuk.com