Skip to content

Moving BaseHook usages to version_compat for segment #52914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 1 commit into from
Jul 6, 2025
Merged

Moving BaseHook usages to version_compat for segment #52914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions providers/segment/src/airflow/providers/segment/hooks/segment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@
import segment.analytics as analytics

from airflow.exceptions import AirflowException

try:
from airflow.sdk import BaseHook
except ImportError:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]
from airflow.providers.segment.version_compat import BaseHook


class SegmentHook(BaseHook):
Expand Down
8 changes: 7 additions & 1 deletion providers/segment/src/airflow/providers/segment/version_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:


AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)

AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)

if AIRFLOW_V_3_0_PLUS:
from airflow.sdk import BaseOperator
Expand All @@ -42,9 +42,15 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
from airflow.models import BaseOperator # type: ignore[no-redef]
from airflow.utils.context import Context # type: ignore[no-redef]

if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import BaseHook
else:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]

# Explicitly export these imports to protect them from being removed by linters
__all__ = [
"AIRFLOW_V_3_0_PLUS",
"BaseHook",
"BaseOperator",
"Context",
]