Add AwaitMessageTrigger for Redis PubSub #52917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
reviewed
Jul 6, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! Thanks for the PR.
Could you help add documentation for this new trigger?
providers/redis/src/airflow/providers/redis/triggers/redis_await_message.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Sure! I've added the documentation for the trigger. |
jason810496
approved these changes
Jul 8, 2025
10 tasks
prdai
reviewed
Jul 13, 2025
providers/redis/src/airflow/providers/redis/triggers/redis_await_message.py
Show resolved
Hide resolved
seanghaeli
approved these changes
Jul 18, 2025
Contributor
seanghaeli
left a comment
seanghaeli
left a comment
There was a problem hiding this comment.
Looks good. Let me know when it's merged, I could take a crack at implementing a deferrable Redis pub sub sensor.
Member
Just merged!
Nice to hear that, thanks! |
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jul 18, 2025
* add redis_pub_sub trigger * add sync_to_async * add docs for Redis trigger * fix = length * fix - length * add Triggers in toctree in index.rst
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Related to #52712.
In order to implement Redis CommonMessageQueueProvider, a trigger for Redis PubSub is a foundational step.
What
Introduces AwaitMessageTrigger for Redis PubSub, enabling async/deferrable sensor support for Redis message channels in Airflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.