Skip to content

Conversation

@Egorees
Copy link
Contributor

@Egorees Egorees commented Jul 7, 2025


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 7, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this, please?

@Egorees
Copy link
Contributor Author

Egorees commented Jul 15, 2025

@sunank200 Can you review, please?

@potiuk
Copy link
Member

potiuk commented Jul 19, 2025

errors

@Egorees
Copy link
Contributor Author

Egorees commented Jul 23, 2025

I've fixed test, but I didn't found how to run CI checks, can you run it or teach me how to do it, please?

@potiuk
Copy link
Member

potiuk commented Jul 23, 2025

I've fixed test, but I didn't found how to run CI checks, can you run it or teach me how to do it, please?

As a new contributor - your workflows need to be approved until your first PR is merged. Just did it. Ping (in general) here if you see them failing and push a fixup- so that they can be re-approved again.

Once your first PR gets merged, the workflows will run automatically

@potiuk potiuk merged commit 194da6a into apache:main Jul 24, 2025
71 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 24, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
…e#52973)

* Add environment and oslogin for yandex dataproc create cluster

* Modify test for new  sdk version

* Fix tests

---------

Co-authored-by: Egor Ermolov <egores@10.211.213.74-vpn.dhcp.yndx.net>
Co-authored-by: Egor Ermolov <egores@10.211.27.67-vpn.dhcp.yndx.net>
Co-authored-by: Egor Ermolov <egores@172.31.55.250-vpn.dhcp.yndx.net>
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
…e#52973)

* Add environment and oslogin for yandex dataproc create cluster

* Modify test for new  sdk version

* Fix tests

---------

Co-authored-by: Egor Ermolov <egores@10.211.213.74-vpn.dhcp.yndx.net>
Co-authored-by: Egor Ermolov <egores@10.211.27.67-vpn.dhcp.yndx.net>
Co-authored-by: Egor Ermolov <egores@172.31.55.250-vpn.dhcp.yndx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants